Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse ion mobility from idXML to PSM object #109

Merged
merged 4 commits into from
Jan 20, 2025
Merged

Parse ion mobility from idXML to PSM object #109

merged 4 commits into from
Jan 20, 2025

Conversation

jonasscheid
Copy link
Contributor

@jonasscheid jonasscheid commented Jan 17, 2025 •
edited by RalfG
Loading

Added

  • io.idxml: Parse ion mobility from idXML files if present.

Follow-up of OpenMS implementation: OpenMS/OpenMS#7701

I know psm_utils can parse ion mobility from spectrum files, but in some cases this might be more convenient :)

paretje
paretje requested changes Jan 17, 2025
View reviewed changes
jonasscheid and others added 2 commits January 17, 2025 19:30
@RalfG
Copy link
Member

RalfG commented Jan 20, 2025

Thanks, @jonasscheid!

For full correctness:

I know psm_utils can parse ion mobility from spectrum files, but in some cases this might be more convenient :)

ms2rescore parses spectrum files, not psm_utils.

@RalfG RalfG closed this Jan 20, 2025
@RalfG RalfG reopened this Jan 20, 2025
@RalfG RalfG merged commit 6258c87 into compomics:main Jan 20, 2025
10 checks passed
@RalfG RalfG added this to the v1.2.1 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paretje paretje paretje requested changes

@RalfG RalfG RalfG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasscheid @RalfG @paretje